Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sophus doesn't build #393

Open
martiege opened this issue Apr 15, 2024 · 1 comment
Open

Sophus doesn't build #393

martiege opened this issue Apr 15, 2024 · 1 comment

Comments

@martiege
Copy link

I'm trying to add the Sophus library to my package, which doesn't seem to build for certain ROS distros. In my case, it is specifically the noetic version that doesn't build, but several others seem not to work either.

I've done some rudimentary testing, and have these results:

foxy: fails
humble: fails
iron: fails
noetic: fails
rolling: builds

It seems that the Sophus package builds the tests and examples, and this is where it crashes. Is there any way of disabling these?
wentasah added a commit to wentasah/nix-ros-overlay that referenced this issue Apr 16, 2024
@wentasah
Fix sophus build errors for humble and iron
6bd6cf8 
We apply the patch from the rolling version, which builds fine already
now. The patch does not apply to foxy and noetic versions so we don't
patch them. Foxy is EOL. If someone needs noetic version, more effort
is needed.

Fixes lopsided98#393
@wentasah wentasah mentioned this issue Apr 16, 2024
Closed
@wentasah
Copy link
Contributor

See #394.

wentasah added a commit to wentasah/nix-ros-overlay that referenced this issue Apr 27, 2024
@wentasah
Fix sophus build errors
d1d2076 
Rolling version builds OK, other versions (noetic, humble, iron) fail.

For ROS 2, we apply the patch which is already rolling. The patch does
not apply to foxy and noetic versions. We ignore Foxy as it is EOL. We
patch noetic by removing explicitly removing "-Werror".

Fixes lopsided98#393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sophus build errors for humble and iron wentasah/nix-ros-overlay
2 participants
@wentasah @martiege