Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk$runInlineQuery inequality conditions #34

Open
tynesjo opened this issue Oct 7, 2019 · 0 comments
Open

sdk$runInlineQuery inequality conditions #34

tynesjo opened this issue Oct 7, 2019 · 0 comments

Comments

@tynesjo
Copy link

tynesjo commented Oct 7, 2019

when the runInlineQuery method of the lookr package SDK object is called then,
if you use a filters argument as a list of the form:
list(variable=condition, variable2=condition2)

where each condition is a string such as ">0",
then each condition ends up being sent to the API as a single-item array (e.g. [">0"]) and not as a string variable ">0", which I believe is not consistent with the API spec.

I applied a patch to fix this to a fork of the package
in the file LookerSDK.R
"filters = filters," -> " filters = lapply(filters, jsonlite::unbox),"

feel free to let me know if the usage of the method is intended to be as described and the fix makes sense, in which case I'd be happy to create a pull request

Thanks for a great package ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant