Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_look needs limit override #11

Open
githoov opened this issue Jul 8, 2016 · 13 comments
Open

run_look needs limit override #11

githoov opened this issue Jul 8, 2016 · 13 comments
Assignees
Labels

Comments

@githoov
Copy link
Contributor

githoov commented Jul 8, 2016

Regenerate Java SDK and include arguments in R wrapper function.

@maxcorbin
Copy link
Contributor

Did this locally with success, will link to pull request when it is available

@maxcorbin
Copy link
Contributor

This was also changed in the latest push, should be able to provide a limit override like so:

run_look(look_id = 1, limit = "20"

Note that for now, limits have to be specified as strings. Update coming on this so users can supply a number.

@ebendutoit
Copy link

Hi there, It seems I can only retrieve 100 rows even though I specify higher values. Is there a limitation?

@maxcorbin maxcorbin reopened this Sep 21, 2016
@maxcorbin
Copy link
Contributor

maxcorbin commented Sep 21, 2016

@eebsidian No, the maximum should be whatever you provide. If you run the same Look in the UI with a 100 row limit set, do you get a warning that you ht the row limit?

@Rich1000
Copy link

+1 from me

@akraemer007
Copy link

+1 from me as well.

@maxcorbin
Copy link
Contributor

Update on this: Due to a problem with swagger, the run_look function won't be able to support limit overrides until Looker's engineering department fleshes out the Look java class a bit more.

However, the limit overrides are working as expected on run_inline_query, so this is the workaround for now!

run_inline_query(model="some_model", view="some_explore", limit="100")

I'll be updating the repository to not accept limit as an argument to run_look until this issue can be resolved. Thanks for your patience everyone!

@Rich1000
Copy link

Any progress on this?

We've got a few people in the company that could start using R to do some really interesting stuff with our modelled data if only they could get it into R.

@githoov
Copy link
Contributor Author

githoov commented Dec 20, 2017

Last I checked, there was a secret workaround: run_look(look_id = 111, limit = "-1"). Though I could imagine the Looker folks doing away with this hack in the long run.

@Rich1000
Copy link

If only I'd known! I created a very simple package to do this in the end: https://github.com/Rich1000/lookr

@maxcorbin maxcorbin self-assigned this Jan 12, 2018
@mermiller
Copy link

+1 from from me too.

@Nigel-Brown
Copy link
Contributor

Nigel-Brown commented Jan 29, 2019

Has any work be done to reinstate the limit option of run_look ?
Error in sdk$runLook(lookId = 7463, limit = "10") :
unused argument (limit = "10")

@ghost
Copy link

ghost commented Nov 8, 2019

What we've done here as a workaround is use a little variable injection in the resultFormat string:
sdk <- lookr::LookerSDK$new(configFile = "looker.ini")
df <- sdk$runLook(lookId = 605, resultFormat = 'json?limit=99999999')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants