Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename note title can output illegal characters (edit: caused by leading space) #67

Open
Propheticus opened this issue Mar 31, 2024 · 1 comment

Comments

@Propheticus
Copy link

Propheticus commented Mar 31, 2024

Since note titles are used to name the corresponding .md file on the filesystem they should not contain characters that are illegal in filenames.

The output of the "Rename note title" is however causing my OneDrive to complain about illegal characters blocking it from syncing files.

EDIT: found out this is related to #66
The output contains a leading space. This is not allowed in (NTFS) filenames. Simply going into explorer and renaming the file, not changing anything (just letting it auto-remove the space), fixes it.

EDIT2: The leading space is actually sent by the application I'm using to run LLM locally.
Still would be a good idea to check and filter out illegal characters for titles that becomes file names.

@Propheticus Propheticus changed the title Change note title add illegal characters Rename note title can output illegal characters Mar 31, 2024
@Propheticus Propheticus changed the title Rename note title can output illegal characters Rename note title can output illegal characters (edit: caused by leading space) Mar 31, 2024
@Propheticus
Copy link
Author

Propheticus commented Mar 31, 2024

Sorry, it's in the response from my local LLM. See below, before the word "Hello":

data: {"choices":[{"delta":{"content":" Hello"},"finish_reason":null,"index":0}],"created":1711886550,"id":"K75WwlMq7nBjqPW4FGlR","model":"_","object":"chat.completion.chunk"}

data: {"choices":[{"delta":{"content":" there"},"finish_reason":null,"index":0}],"created":1711886550,"id":"ADqnjtzqwx1zbUiWVXVm","model":"_","object":"chat.completion.chunk"}

caused by janhq/jan#2548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant