Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable "ok" resonse #67

Closed
jakommo opened this issue Jun 24, 2017 · 3 comments
Closed

Add option to disable "ok" resonse #67

jakommo opened this issue Jun 24, 2017 · 3 comments
Labels
adoptme enhancement hacktoberfest "Everyone is welcome, Quantity is fun, quality is key, Short term actions, long term impact"

Comments

@jakommo
Copy link

jakommo commented Jun 24, 2017

It seems like the "ok" response is hardcoded.
I'm using a cronjob to send nmap data to the http input, similar to what is described in this blog post.
The issue with the ok response is that it causes an email from cron being generated, every time the job runs, which is annoying.
I know that I can redirect the output, but I can imagine that there are other use cases where no response would be appreciated as well.
Proposing to add an option to disable the response.

@ebuildy
Copy link
Contributor

ebuildy commented May 11, 2018

we could add an option to specify the response?

@robbavey robbavey added adoptme hacktoberfest "Everyone is welcome, Quantity is fun, quality is key, Short term actions, long term impact" labels Oct 1, 2018
@Ronookkeli
Copy link

It would be useful if the response payload could be specified. Some Soap web service interfaces expect to receive Soap-message in the response payload when http 200 is responded, and do not accept the current response payload of 'ok'. Other thing, nice to have, would be able to respond http 202 Accepted with empty payload.

@jsvd
Copy link
Member

jsvd commented Dec 2, 2019

adding a note here: setting response_code => 204 (No Content) will not return a response body.

I'm closing this issue as the original goal of disabling ok responses is implemented, and adding #117 to track the configuration of the response_body string.

@jsvd jsvd closed this as completed Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adoptme enhancement hacktoberfest "Everyone is welcome, Quantity is fun, quality is key, Short term actions, long term impact"
Projects
None yet
Development

No branches or pull requests

5 participants