Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of pubsub seems incorrect #115

Open
jamesporritt opened this issue Dec 7, 2016 · 2 comments
Open

Implementation of pubsub seems incorrect #115

jamesporritt opened this issue Dec 7, 2016 · 2 comments

Comments

@jamesporritt
Copy link

The pubsub attribute in mockredis/client.py seems to be defined as a defaultdict that stores the lines passed by publish, whereas it should be a method that creates an object of PubSub(), that handles the subscription to the channel. We would still need that defaultdict under the cover and linked to the mocked PubSub instances that are handed out.

@alertedsnake
Copy link

alertedsnake commented Mar 1, 2017

I agree, this current implementation is completely broken, so I can't use this module at all.

Is the pubsub feature on the roadmap to be completed soon?

I had some time, so I hacked this out :)

@MPalarya
Copy link

MPalarya commented Jun 9, 2022

@alertedsnake 5 years later - thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants