Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the scheduled transition when the review entitiy is deleted or vice versa #98

Open
andybroomfield opened this issue May 20, 2024 · 1 comment

Comments

@andybroomfield
Copy link
Contributor

In order to uninstall, we need to delete all the the review date entities.
Except doing this will leave the scheduled transitions in place.
So we need a way to saftly remove the scheduled transitions and then remove the entitiy.
The review date entiity does store the transition id, so we can use that.
Also should apply the same vice versa.

@stephen-cox
Copy link
Member

It's easy enough to add a hook to delete the associated scheduled transition entity when deleting a review date entity.

One concern is as scheduled transitions are separately managed, it is possible a user may use one created by the review date for some other purpose. This is probably quite unlikely, but it is something we should at least consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants