New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Quote template to follow Drupal Coding Standards #72

Open

markconroy opened this issue Jan 10, 2022 · 0 comments

Member

markconroy commented Jan 10, 2022 •

edited

Loading

Creates classes variable
Uses attributes so we have attributes for accessibility, quick edit, etc
Removes p around the quote, as this was resulting in an empty p tag, since the field itself renders a div inside it
Checks if the author field is filled in before rendering it, or else we get an empty footer

We had a PR for this, but it was against a fork of this repo I created in the early days, so creating a new issue/PR now to do this properly.

What I am proposing here is to use the same markup that we have in the localgov_base theme, for better inheritability for CSS, etc.

markconroy mentioned this issue

rewrites quote template to follow Drupal coding standards #73

Draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment