Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking to non-D8 pages from D8 landing pages #93

Closed
OliverHannan opened this issue Mar 12, 2021 · 5 comments
Closed

Linking to non-D8 pages from D8 landing pages #93

OliverHannan opened this issue Mar 12, 2021 · 5 comments

Comments

@OliverHannan
Copy link

OliverHannan commented Mar 12, 2021

Adding either external or D7 links to D8 landing pages, there is no option to add summary text, summary text is not pulled through from D7 pages. Just left with the title - see these 2 pages.

image

https://lbc-app-w-corpwebsite-p.azurewebsites.net/business-licences-and-tenders/running-business/business-support-and-advice

image

https://lbc-app-w-corpwebsite-p.azurewebsites.net/business-licences-and-tenders/running-business

Is there any way to rectify or bypass this?

@andybroomfield
Copy link
Contributor

BHCC Would also be interested in this (Our solution is to set up redirect pages that can be included with a teaser, but then link off).

What would be the best way forward? A field formatter that if its an external link could add a custom summary?

@danchamp
Copy link
Collaborator

BHCC Would also be interested in this (Our solution is to set up redirect pages that can be included with a teaser, but then link off).

Cumbria have also just bumped up against this issue. I came up with the same workaround @andybroomfield but it's a bit ugly!

@andybroomfield
Copy link
Contributor

I think there is scope here to change the link format fir sub hubs as they are paragraphs (or are they link fields) and have the option to craft a custom snippet here if something can't be picked up.

Else the alternative would be to have a crawler go out and fetch the external page and use the meta description tag.

@andybroomfield
Copy link
Contributor

A quick bump on this.
I notice in sub landing module (and in legacy BHCC code) there is a dummy-teaser.html.twig template that gets used for external links. This has space for the link title and url. It could be expanded to also include some teaser text? and the field widget could add extra support for a manually crafted teaser.
External links seem to crop up a lot, and as its a link field not an entity reference, they should be supported.
This could also extend to support links to pages that do not have teasers such as views so there is fallback to implement some summary text.

@willguv
Copy link
Member

willguv commented Mar 23, 2022

Replaced by #152 with an updated description, linked back here for conversation

@willguv willguv closed this as completed Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants