Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geocoder version flexibility for upgrades from Drupal 9 to 10 #105

Open
finnlewis opened this issue Nov 12, 2023 · 2 comments
Open

Geocoder version flexibility for upgrades from Drupal 9 to 10 #105

finnlewis opened this issue Nov 12, 2023 · 2 comments

Comments

@finnlewis
Copy link
Member

When upgrading from Drupal 9 to Drupal 10, Upgrade Status reports that geocoder is incompatible:

image

I am wondering if allowing multiple versions of geocoder might allow people to update geocoder before updatign to Drupal 10.

So changing the dependency to :

"drupal/geocoder": "^3.7 || ^4.10",

I realise this is probably a bit late, with Drupal 9 being end of life, but some people are yet to upgrade from Drupal 9.

@andybroomfield
Copy link
Contributor

From composer why on Drupal 10.

$ composer why drupal/geocoder
drupal/geo_entity             1.0.0-beta5 requires drupal/geocoder (^4.4)          
localgovdrupal/localgov_forms 1.0.0-beta2 requires drupal/geocoder (^3.20 || ^4.0) 

So when you upgrade and get geo entity, sites will get geocoder 4. Though interestingly localgov_forms can use both.

I thought the problem was that localgov_geo itself is not compatible with geocoder 4 which is why it was initially getting a new release, but then geo_entitiy took over.

@ekes
Copy link
Member

ekes commented Nov 13, 2023

I thought the problem was that localgov_geo itself is not compatible with geocoder 4

Reading the code there's little difference between 3 and 4, not quite sure what the backward compatibility break is... but for #106 (comment) which suggests maybe it's Guzzle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants