Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lgd:icon SDC doesn't use theme variable #705

Open
ctorgalson opened this issue Jan 23, 2025 · 0 comments
Open

lgd:icon SDC doesn't use theme variable #705

ctorgalson opened this issue Jan 23, 2025 · 0 comments
Assignees
@ctorgalson
Labels
bug Something isn't working

Comments

@ctorgalson
Copy link
Contributor

ctorgalson commented Jan 23, 2025 •
edited
Loading

The lgd:icon SDC accepts a theme variable, but doesn't make any use of it. This makes it impossible to use any icon from outside of localgov_base, largely defeating the purpose of the SDC :)

This is somewhat mitigated by the fact that the variable was only added when I converted the existing Twig template to an SDC, and is not documented.

PR to follow shortly.
@ctorgalson ctorgalson added the bug Something isn't working label Jan 23, 2025
@ctorgalson ctorgalson self-assigned this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctorgalson ctorgalson

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctorgalson