Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content access by path - documentation #638

Open
willguv opened this issue Nov 7, 2023 · 17 comments
Open

Content access by path - documentation #638

willguv opened this issue Nov 7, 2023 · 17 comments
Assignees

Comments

@willguv
Copy link
Member

willguv commented Nov 7, 2023

Work in progress: This module adds access control to your LGD site sections, which allows you to restrict editing/publishing/etc actions to subsets of users.

https://github.com/localgovdrupal/localgov_content_access_control

@willguv willguv converted this from a draft issue Nov 7, 2023
@willguv willguv changed the title access control module Access control module Nov 7, 2023
@willguv
Copy link
Member Author

willguv commented Nov 8, 2023

@willguv willguv moved this from In Progress - Core team to In Progress - Everyone else in 2025 backlog Jan 13, 2024
@willguv willguv changed the title Access control module Content access by path Feb 14, 2024
@willguv
Copy link
Member Author

willguv commented Feb 14, 2024

New module - content access by path
https://youtu.be/LboXz5b72XY?si=vfOel3GGhMEH54sC

@willguv
Copy link
Member Author

willguv commented Mar 13, 2024

@markconroy can we talk about adding media paths to this? How much effort please - thanks

@markconroy
Copy link
Member

@willguv media doesn't have paths by default - media URLs are just /media/123 but site visitors should be be able to visit those URLs, they are only for admins to edit media.

For that reason, I don't think this media is suitable for "content access by path". Especially since media should be shared across a site (that's the whole point of media library). If we gave media a URL of say /media/fostering/hero.jpg, it's very conceivable that the homepage or some other page would also want to use that image as a teaser in a component.

@willguv
Copy link
Member Author

willguv commented Apr 10, 2024

@markconroy have you pushed this back to LGD? No worries if not, just seeing where we've got to

@markconroy
Copy link
Member

Do you mean to add content_access_by_path to the default install of LGD?

I haven't done that yet. Do we want it as part of the default install?

@willguv
Copy link
Member Author

willguv commented Apr 10, 2024

I'm thinking yes part of the default install but maybe switched off?

@markconroy
Copy link
Member

PR for this: localgovdrupal/localgov_core#215

@willguv willguv moved this from In Progress - Everyone else to Review in 2025 backlog Jun 20, 2024
@willguv
Copy link
Member Author

willguv commented Sep 25, 2024

We've agreed to not include this by default, but document it. I'll find the related card and close this one

@willguv willguv changed the title Content access by path Content access by path - documentation Sep 25, 2024
@Dixonj1
Copy link

Dixonj1 commented Oct 1, 2024

@markconroy we've tested this and authors can still publish new content anywhere on the site, even if they're restricted to editing certain sections of it. Is that right?

@markconroy
Copy link
Member

@Dixonj1, yes, I don't see why we would stop them from placing content somewhere.

I guess we could have a checkbox on the settings page to say "Only allow editors to save content within the paths they are allowed to edit". I'm not fully-sure how that would work, but I could give it a try.

@Dixonj1
Copy link

Dixonj1 commented Oct 7, 2024

@markconroy that would be really useful for us, thanks. If we're restricting author access we need to be able to stop them publishing content.

@markconroy
Copy link
Member

Issue created - https://www.drupal.org/project/content_access_by_path/issues/3479092

@Dixonj1
Copy link

Dixonj1 commented Oct 14, 2024

@markconroy we've discovered that if an author has created a page, this overrides restrictions through content access by path. If the piece of content they created is outside of their restricted content, they can still edit it. It would be worth letting people know this in the documentation.

@markconroy
Copy link
Member

@Dixonj1 That is by design. Editors can edit

  1. Items within their allowed paths, and
  2. Items that they are the author of

The second part is deliberate. If not, and they create a piece of content with the wrong path by accident, they would not be able to then edit it to set the right path.

@willguv
Copy link
Member Author

willguv commented Dec 9, 2024

@willguv willguv moved this from In Progress - Everyone else to In Progress - Core team in 2025 backlog Dec 19, 2024
@willguv willguv assigned willguv and unassigned markconroy Dec 19, 2024
@willguv willguv moved this from In Progress - Core team to Review in 2025 backlog Jan 30, 2025
@willguv
Copy link
Member Author

willguv commented Jan 30, 2025

PR here localgovdrupal/docs#303

@willguv willguv moved this from Review to Documentation in 2025 backlog Feb 4, 2025
@willguv willguv moved this from Documentation to Done in 2025 backlog Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants