Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[X86] X86InstrFragments.td - replace def32 with something that will fail-safe #122104

Open
RKSimon opened this issue Jan 8, 2025 · 1 comment

Comments

@RKSimon
Copy link
Collaborator

RKSimon commented Jan 8, 2025

This came up recently in #114360 - the def32 pattern to detect implicit i32->i64 zero extension can get things wrong under certain circumstances depending on ordering in DAGISel and assume the upper 32-bit are already zero when they aren't.

We might be better off just having a pass that removes unnecessary zext nodes later on.

@llvmbot
Copy link
Member

llvmbot commented Jan 8, 2025

@llvm/issue-subscribers-backend-x86

Author: Simon Pilgrim (RKSimon)

This came up recently in #114360 - the def32 pattern to detect implicit i32->i64 zero extension can get things wrong under certain circumstances depending on ordering in DAGISel and assume the upper 32-bit are already zero when they aren't.

We might be better off just having a pass that removes unnecessary zext nodes later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants