Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with column widths on TB startup #24

Open
Pit-99 opened this issue Jul 23, 2024 · 6 comments
Open

Problem with column widths on TB startup #24

Pit-99 opened this issue Jul 23, 2024 · 6 comments

Comments

@Pit-99
Copy link

Pit-99 commented Jul 23, 2024

Since rev. 1.1.2, there is still a problem with the emails' list (a similar issue was already mentioned by another user some weeks ago):
In most cases, after starting TB

  • the additional column (Sender (@) in my case) does not appear in the column headers
  • the width of all columns is not correct (too wide or too small), so the list is unreadable
    After deactivating/reactivating the AddOn (without restarting TB) the list is ok.
    Applies to: TB 115.12.2, AddOn Rev. 1.2.0
    Screenshot (top half shows the correct list, bottom half shows the problem):
    Bild2
@lkosson
Copy link
Owner

lkosson commented Jul 23, 2024

There is old issue #7, which is most likely unrelated (pre-Supernova TB) and a comment in #14 (from 2024-05-17).

So far I have witnessed this behavior only once and I don't know a reliable way to reproduce it. The columns reverted back to normal when switching folders, so I didn't got a chance to debug it. There were no significant messages in TB console.

Until it appears again on my PC or I find a way to somehow reproduce it, there is not much I can do about it.

@lkosson
Copy link
Owner

lkosson commented Jul 24, 2024

Upon further investigation, it looks like some kind of race condition between adding custom columns and restoring saved/default folder settings. thead of the table contains ths for default column set (22 of them, as declared in initializer of ThreadPaneColumns.DEFAULT_COLUMNS), while tbody contains tds with custom columns' cells prepended (26 of them in total). Furthermore, threadPane.columns (from about3Pane.js) still contains original set of 22 columns, while ThreadPaneColumns.DEFAULT_COLUMNS contains 26 columns (including custom columns registered by the addon).

I'll try asking TB team to confirm whether this is a bug in the client.

@lkosson
Copy link
Owner

lkosson commented Jul 24, 2024

Temporary workaround: switch to some other folder you don't really care about and select "Restore default columns". This will reset settings for that folder, but as a side effect it will update threadPane.columns from ThreadPaneColumns.DEFAULT_COLUMNS, which should fix all other folders too, without resetting their settings.

@lkosson
Copy link
Owner

lkosson commented Jul 24, 2024

Looks like a bug in TB: https://bugzilla.mozilla.org/show_bug.cgi?id=1909621

@Pit-99
Copy link
Author

Pit-99 commented Jul 24, 2024

Upon further investigation, it looks like some kind of race condition between adding custom columns and restoring saved/default folder settings.

Sounds plausible; I also had the impression, that this may be a timing problem, kind of.
As I see, the problem is reproducible, and there is a bug report meanwhile, so let's hope, that it will be fixed soon.
Thank you very much for your investigations and your efforts.

As workaround I switch off/on the AddOn, so any columns' settings will not be affected.

@lkosson
Copy link
Owner

lkosson commented Nov 12, 2024

Should be fixed in Thunderbird 134.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants