Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop tools/lkl/bin binaries #539

Open
ddiss opened this issue May 14, 2024 · 1 comment
Open

drop tools/lkl/bin binaries #539

ddiss opened this issue May 14, 2024 · 1 comment

Comments

@ddiss
Copy link

ddiss commented May 14, 2024

The opaque Android (ld.gold) and Windows (as, ld, objcopy) binaries currently carried under tools/lkl/bin/ are very difficult to verify and audit. IMO they should be dropped in favour of some form of environmental dependency.

@thehajime
Copy link
Member

same as #538, I'm fine if we keep this in the lkl repository or move it to somewhere else.

IIRC, the original intention on those supplemental binary files is to remove in future, when upstream toolset (binutils, etc) accepts our fixes. So, those are temporary one and never planned to upstream to Linux mainline.

ddiss added a commit to ddiss/opensuse-kernel that referenced this issue Jan 24, 2025
Some Windows and arm binaries are carried under tools/lkl/bin that
needn't be. Delete them and only retain the bin/lkl-hijack.sh wrapper
script.
This will break Windows and Android builds / CI unless $PATH is updated
to point to similar binaries. Plain builds on Linux should still be
fine.
A bin/README.txt file is added to document the directory's
PATH-precedence use for BSD builds.

Link: lkl/linux#539
Acked-by: David Disseldorp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants