-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSYS2 toolchain no longer works out of the box #289
Comments
I consider it a regression that they dropped the patches for weak externals. Have you tried filing a bug report with them? |
No, I'll do that now. However I suspect the reason is that that the patches don't apply cleanly on binutils 2.25.1. I'm rebasing them now and I'll PR them to MSYS2. |
I sent a PR. @tavip I had to do some minor changes to your patches in order for them to apply on 2.25.1. If could take a look at them it would be great since I'm not very familiar with the binutils codecase. msys2/MSYS2-packages#785 |
The changes looks good to me, I've left a message in the PR too :) More importantly, if the LKL buid and tests pass, it should be fine, since it stresses this feature pretty well. |
The MinGW-version of the package is lacking the patch as well. Any takers? ;-) |
In March MSYS2 rolled back the version of binutils to 2.15 that doesn't include the weak NT externals patches. msys2/MSYS2-packages@660ffd3
One can use the following workaround to install the previous version:
The text was updated successfully, but these errors were encountered: