Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LiveView Native Clients: Support live_render to render one liveview within another #64

Open
AZholtkevych opened this issue Dec 6, 2023 · 0 comments
Assignees

Comments

@AZholtkevych
Copy link

AZholtkevych commented Dec 6, 2023

https://dockyard.slack.com/archives/C02E1GA5THB/p1701882344052169

bcardarella
12:05 PM
@May Matyi
I'm reproducing Chris' original thermostat LV demo and he uses live_render to render one liveview within another. Do we support that?
12:06
I'm guessing we do not

May Matyi
12:11 PM
@bcardarella
I actually haven’t tested that so I’m not sure? If you’re working off main you could try this, if that doesn’t work it’s something we’ll have to add support for
Untitled

live_render(conn_or_socket, SomeLiveView, session: %{"lvn" => %{"format" => "swiftui"}})

12:11
you could also refactor it to use a LiveComponent, which are working

bcardarella
12:12 PM
I recall discussing this very early on with Anil but I'm pretty certain it wasn't implemented. I'm not yet working with LVN I'm currently porting his demo to a modern phoenix install
New

May Matyi
12:12 PM
oops that snippet was wrong, fixed
12:12
oh gotcha
12:14
I’ve only used live_render a few times when I was migrating Phoenix controllers to LiveView for a project since it lets you render a LiveView in a dead template
12:14
so I’m not really sure how it works lol

bcardarella
12:16 PM
yeah I think we'll have to scope this out for LVN Core, I don't think it is worth trying to get into the swiftui client at this point. Maybe that can be a v0.4 thing. I honestly don't know how often people are using live_render to render LVs within LVs. I'll have to figure out what type of priority this is

alex.zholtkevych
12:17 PM
Adding issue in case of not to forget

@AZholtkevych AZholtkevych converted this from a draft issue Dec 6, 2023
@AZholtkevych AZholtkevych assigned simlay and unassigned KronicDeth Mar 19, 2024
@AZholtkevych AZholtkevych moved this from Todo to In Progress in LiveViewNative Core Apr 4, 2024
@AZholtkevych AZholtkevych changed the title Support live_render to render one liveview within another LiveView Native Clients: Support live_render to render one liveview within another Apr 20, 2024
@AZholtkevych AZholtkevych mentioned this issue Apr 20, 2024
26 tasks
@AZholtkevych AZholtkevych moved this from In Progress to Todo in LiveViewNative Core Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants