Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect/3 doesn't match behaviour on the web #336

Open
BrooklinJazz opened this issue Apr 17, 2024 · 2 comments
Open

redirect/3 doesn't match behaviour on the web #336

BrooklinJazz opened this issue Apr 17, 2024 · 2 comments
Assignees

Comments

@BrooklinJazz
Copy link

On the web, live navigation has the following behavior:

  • redirect re-establish socket connection and re-mount the liveview
  • push_navigate re-use existing socket connection and re-mount the liveview
  • push_patch re-use existing socket connection and existing liveview (no mount/3, only handle_params)

However, on native our redirect event re-uses the existing socket connection rather than re-establishing it. I think this could be a potential security risk, or at the very least, doesn't match what developers will expect.

@carson-katri
Copy link
Collaborator

This issue should be moved to the SwiftUI client

@carson-katri carson-katri transferred this issue from liveview-native/live_view_native Apr 19, 2024
@bcardarella bcardarella self-assigned this Sep 17, 2024
@bcardarella
Copy link

I'll test this to see if it is still valud

@bcardarella bcardarella reopened this Sep 17, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in LiveView Native SwiftUI Sep 17, 2024
@bcardarella bcardarella transferred this issue from liveview-native/liveview-client-swiftui Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants