From cbc8c74edc0595a70423a3794ae1eb38a6fca983 Mon Sep 17 00:00:00 2001 From: Mingliang Liu Date: Wed, 4 Dec 2024 21:31:32 -0800 Subject: [PATCH] Address comment to make getMetadataSize abstract in the base class --- .../flink/runtime/checkpoint/AbstractCheckpointStats.java | 6 ++---- .../flink/runtime/checkpoint/PendingCheckpointStats.java | 5 +++++ .../checkpoint/DefaultCheckpointStatsTrackerTest.java | 2 +- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/AbstractCheckpointStats.java b/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/AbstractCheckpointStats.java index be4bc295f6fd9..4f8a692968306 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/AbstractCheckpointStats.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/AbstractCheckpointStats.java @@ -93,10 +93,8 @@ public abstract class AbstractCheckpointStats implements Serializable { */ public abstract long getCheckpointedSize(); - /** @return The metadata file size, 0 if unknown. */ - public long getMetadataSize() { - return 0; - } + /** @return The metadata file size. */ + public abstract long getMetadataSize(); /** @return the total number of processed bytes during the checkpoint. */ public abstract long getProcessedData(); diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpointStats.java b/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpointStats.java index 6a315db562328..efde74ec81791 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpointStats.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpointStats.java @@ -155,6 +155,11 @@ public long getStateSize() { return currentStateSize; } + @Override + public long getMetadataSize() { + return 0; + } + @Override public long getCheckpointedSize() { return currentCheckpointedSize; diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/DefaultCheckpointStatsTrackerTest.java b/flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/DefaultCheckpointStatsTrackerTest.java index 8b2bf65cb57fd..ff95b64f8179a 100644 --- a/flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/DefaultCheckpointStatsTrackerTest.java +++ b/flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/DefaultCheckpointStatsTrackerTest.java @@ -402,7 +402,7 @@ public void addSpan(SpanBuilder spanBuilder) { pending.reportSubtaskStats(jobVertexID, createSubtaskStats(0, true)); // Complete checkpoint => new snapshot - tracker.reportCompletedCheckpoint(pending.toCompletedCheckpointStats(null)); + tracker.reportCompletedCheckpoint(pending.toCompletedCheckpointStats(null, 1984)); assertThat(reportedSpans.size()).isEqualTo(1); reportedSpan = Iterables.getOnlyElement(reportedSpans);