revert the fix for apache#3387

liukun4515 · Sep 16, 2022 · cbe943b · cbe943b
1 parent 3013e04
commit cbe943b
Showing 1 changed file with 14 additions and 6 deletions.
diff --git a/datafusion/expr/src/binary_rule.rs b/datafusion/expr/src/binary_rule.rs
@@ -297,6 +297,13 @@ fn mathematics_numerical_coercion(
         return None;
     };
 
+    // same type => all good
+    // TODO: remove this
+    // bug: https://github.com/apache/arrow-datafusion/issues/3387
+    if lhs_type == rhs_type {
+        return Some(lhs_type.clone());
+    }
+
     // these are ordered from most informative to least informative so
     // that the coercion removes the least amount of information
     match (lhs_type, rhs_type) {
@@ -895,12 +902,13 @@ mod tests {
             DataType::Float64
         );
         // decimal
-        test_coercion_binary_rule!(
-            DataType::Decimal128(10, 2),
-            DataType::Decimal128(10, 2),
-            Operator::Plus,
-            DataType::Decimal128(11, 2)
-        );
+        // bug: https://github.com/apache/arrow-datafusion/issues/3387 will be fixed in the next pr
+        // test_coercion_binary_rule!(
+        //     DataType::Decimal128(10, 2),
+        //     DataType::Decimal128(10, 2),
+        //     Operator::Plus,
+        //     DataType::Decimal128(11, 2)
+        // );
         test_coercion_binary_rule!(
             DataType::Int32,
             DataType::Decimal128(10, 2),