From db730b8817a0cf93c781181869840d1e5daf22d6 Mon Sep 17 00:00:00 2001 From: "Bryson G." Date: Wed, 19 Feb 2025 11:16:02 -0800 Subject: [PATCH] refactor: perform id construction on client --- .../(diagram)/wfRun/[...ids]/components/WfRun.tsx | 3 ++- .../[tenantId]/(diagram)/wfRun/[...ids]/page.tsx | 6 +----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/dashboard/src/app/(authenticated)/[tenantId]/(diagram)/wfRun/[...ids]/components/WfRun.tsx b/dashboard/src/app/(authenticated)/[tenantId]/(diagram)/wfRun/[...ids]/components/WfRun.tsx index d4b5f22cd..415c7252d 100644 --- a/dashboard/src/app/(authenticated)/[tenantId]/(diagram)/wfRun/[...ids]/components/WfRun.tsx +++ b/dashboard/src/app/(authenticated)/[tenantId]/(diagram)/wfRun/[...ids]/components/WfRun.tsx @@ -9,7 +9,8 @@ import { useWfRun } from '@/app/hooks/useWfRun' import { WfRunId, WfRunVariableAccessLevel } from 'littlehorse-client/proto' import { isExternal } from 'util/types' -export const WfRun: FC<{ wfRunId: WfRunId, tenantId: string }> = ({ wfRunId, tenantId }) => { +export const WfRun: FC<{ ids: string[], tenantId: string }> = ({ ids, tenantId }) => { + const wfRunId: WfRunId = ids.reduce((wfRunId, id, i) => (i === 0 ? { id } : { id, parentWfRunId: wfRunId }), {} as WfRunId); const searchParams = useSearchParams() const threadRunNumber = Number(searchParams.get('threadRunNumber')) const { wfRunData, isLoading, isError } = useWfRun({ wfRunId, tenantId }) diff --git a/dashboard/src/app/(authenticated)/[tenantId]/(diagram)/wfRun/[...ids]/page.tsx b/dashboard/src/app/(authenticated)/[tenantId]/(diagram)/wfRun/[...ids]/page.tsx index f72634d60..466ec386f 100644 --- a/dashboard/src/app/(authenticated)/[tenantId]/(diagram)/wfRun/[...ids]/page.tsx +++ b/dashboard/src/app/(authenticated)/[tenantId]/(diagram)/wfRun/[...ids]/page.tsx @@ -2,16 +2,12 @@ import { Metadata } from 'next' import { notFound } from 'next/navigation' import { ClientError, Status } from 'nice-grpc-common' import { WfRun } from './components/WfRun' -import { getWfRun } from '../../../../../actions/getWfRun' -import { WfRunId } from 'littlehorse-client/proto' type Props = { params: { ids: string[]; tenantId: string } } export default async function Page({ params: { ids, tenantId } }: Props) { - const wfRunId: WfRunId = ids.reduce((wfRunId, id, i) => (i === 0 ? { id } : { id, parentWfRunId: wfRunId }), {} as WfRunId); - try { - return + return } catch (error) { if (error instanceof ClientError && error.code === Status.NOT_FOUND) return notFound() throw error