Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tied_b initialized to None instead of True in ConvElemWise #1430

Open
GeertLitjens opened this issue Mar 12, 2015 · 4 comments · May be fixed by #1433
Open

tied_b initialized to None instead of True in ConvElemWise #1430

GeertLitjens opened this issue Mar 12, 2015 · 4 comments · May be fixed by #1433
Labels
CCW For beginners Incorrect answer bug

Comments

@GeertLitjens
Copy link
Contributor

tied_b should be initialized to True according to the documentation. However, it is initialized to None, essentially resulting in a default value of False. Either the documentation or the default value should be updated.
@lamblin
Copy link
Member

lamblin commented Mar 12, 2015

The code is at https://github.com/lisa-lab/pylearn2/blob/master/pylearn2/models/mlp.py#L2930
Having a default value of None in the constructor is not really the problem (it allows to discriminate between the default behaviour and an explicit True), but the constructor should set self.tied_b = True if None was passed.

@GeertLitjens GeertLitjens linked a pull request Mar 13, 2015 that will close this issue
Open
@mark-schultz-wu
Copy link

Hi, is this as simple as including a line of if tied_b is None: self.tied_b = True?

@nouiz
Copy link
Member

nouiz commented Mar 23, 2017

I don't know. I just want to tell that pylearn2 isn't supported anymore. There is no more dev here.

@lamblin
Copy link
Member

lamblin commented Mar 23, 2017

@mark-schultz If you need that behaviour, this should be all the changes you need to make to your local copy of Pylearn2.
As far as I remember, the main issue was how to handle the change of behaviour for existing users and scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CCW For beginners Incorrect answer bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ConvElemwise now sets tied_b to the correct default
4 participants
@lamblin @nouiz @GeertLitjens @mark-schultz-wu