Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counter-intuitive password reveal button #215

Open
hsbasu opened this issue Jan 28, 2023 · 4 comments
Open

Counter-intuitive password reveal button #215

hsbasu opened this issue Jan 28, 2023 · 4 comments

Comments

@hsbasu
Copy link
Contributor

hsbasu commented Jan 28, 2023

 * slick-greeter version 1.6.1 (self-built from master branch)
 * Distribution - UCR 22.04 LTS
 * 64 bit

Issue
Password reveal button is visible only after clicking on password prompt entry.

Steps to reproduce

  1. Start system.
  2. Start typing password.
  3. No Password reveal button
  4. Click on password prompt entry
  5. Password reveal button is shown.

Expected behaviour
After Step 1, password reveal button should be visible and should not need any click.

Other information

slick-greeter-test.mp4
@clefebvre
Copy link
Member

I'm on the fence on this.. you may be right. Let's gather feedback during BETA and decide then.

@hsbasu
Copy link
Contributor Author

hsbasu commented Jun 2, 2023

Hi! @clefebvre . Thanks for your feedback. The features I would suggest is:

  1. The login button (right arrow icon in the password entry box), which is now a primary icon of th GTK entry, may be kept outside on the right side of the entry box.
  2. The password reveal icon may replace the login icon and is visible whenever the password entry is changed.

I tried to implement them in the code but I am not good at vala language. But I was able to track the code in prompt-box.vala:line 521, 530 and 535

@PacketFiend
Copy link

I will second this.

As currently implemented, it's not obvious to a user at all how they would reveal a password. My use case is my wife, who normally uses a tablet but occasionally (maybe once a month) needs a "real computer" for something. She has an account on my workstation for that purpose. Her password is five or six dictionary words - passwords that long become incredibly frustrating to enter if you don't have a password reveal button.

I assume people who rarely encounter slick-greeter will not understand how to reveal the password. It's very much becoming commonplace and best practice now that a "reveal password" button should be visible, and not "psuedo-hidden" like it is currently.

Or, even a "Press F8 to reveal password" infobox would serve the same purpose - something to inform people who don't generally encounter this app.

1 similar comment
@PacketFiend
Copy link

I will second this.

As currently implemented, it's not obvious to a user at all how they would reveal a password. My use case is my wife, who normally uses a tablet but occasionally (maybe once a month) needs a "real computer" for something. She has an account on my workstation for that purpose. Her password is five or six dictionary words - passwords that long become incredibly frustrating to enter if you don't have a password reveal button.

I assume people who rarely encounter slick-greeter will not understand how to reveal the password. It's very much becoming commonplace and best practice now that a "reveal password" button should be visible, and not "psuedo-hidden" like it is currently.

Or, even a "Press F8 to reveal password" infobox would serve the same purpose - something to inform people who don't generally encounter this app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants