share deaduntils between hosts #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octupszhang
force-pushed
the
shareHostDeadUntils
branch
from
52c4c91 to
f64c7f9
Compare
This will help avoid many socket timeout especially when we use python-memcached with eventlet. For example,When use eventlet,for each greenlet we call client.get first time,the client will be rebuild,and client.servers[*].deaduntil will be 0.For each http request,we will have one greenlet.So we get a socket timeout for each request. This could be fixed in application,but i believe it's better to fix it in python-memcached.
octupszhang
force-pushed
the
shareHostDeadUntils
branch
2 times, most recently
from
39591e3 to
0d5281e
Compare
linsomniac
reviewed
Dec 17, 2016
| @@ -1330,6 +1330,9 @@ def check_key(self, key, key_extra_len=0): | |||
| "Control/space characters not allowed (key=%r)" % key) | |||
|
|
|||
|
|
|||
| _host_last_deaduntils = {} | |||
There was a problem hiding this comment.
This never gets reset, once a host becomes alive should there be a "del _host_list_deaduntils[self.ip)"?
There was a problem hiding this comment.
Glad to get your response, how about the new patch, I think maybe "_host_list_deaduntils[self.ip]=0" is better, which avoids KeyError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help avoid many socket timeout especially when we use
python-memcached with eventlet.
For example,When use eventlet,for each greenlet we call client.get
first time,the client will be rebuild,and client.servers[*].deaduntil
will be 0.For each http request,we will have one greenlet.So we get
a socket timeout for each request.
This could be fixed in application,but i believe it's better to fix
it in python-memcached.