Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customisation of grafana helm values for teams #1649

Open
mcalr3 opened this issue Jul 12, 2024 · 1 comment
Open

Allow customisation of grafana helm values for teams #1649

mcalr3 opened this issue Jul 12, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@mcalr3
Copy link

mcalr3 commented Jul 12, 2024

By default, we cannot override the helm values (in the same way as rawValues in team-admin) for team level apps.

A use case for this is adding plugins to the plugins array in the grafana helm chart.

As a workaround, we have had to disable the monitoring stack for each team from otomi, and deploy it manually via an argoCD app. This allows us to override helm values such as the plugins in grafana. It allows us also to add additional datasources and make use of the envFrom helper in the helm chart. If we were to deploy configMaps separately for additional datasources, there's no way to hide the secrets from git (other than using a pipeline to decrypt them via SOPS). We are aware of the limitations of this workaround such as no automatic updating of changed keycloak clientsecret etc.

Is it possible to add the rawValues override for team level apps (such as prometheus stack) easily, or will this require additional values schemas to be added for each chart to validate them?

@mcalr3 mcalr3 added the enhancement New feature or request label Jul 12, 2024
@j-zimnowoda
Copy link
Contributor

Hi @mcalr3.
We are going to consider your proposal. For time being, you could use SealedSecrets to store passwords securely in git.
In the ArgoApp you could reference the secret name. Would that solve the secrets issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants