From 36216561f903e1a9c2a4022f86e56c36b4d1fe19 Mon Sep 17 00:00:00 2001 From: Kevin Schaper Date: Wed, 22 Jun 2022 15:10:03 -0700 Subject: [PATCH 1/4] Explicitly start solr after installing dependencies and before tests --- .github/workflows/pr-test.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-test.yaml b/.github/workflows/pr-test.yaml index 254f858..c3a2d44 100644 --- a/.github/workflows/pr-test.yaml +++ b/.github/workflows/pr-test.yaml @@ -30,7 +30,10 @@ jobs: with: path: .venv key: venv-${{ runner.os }}-${{ hashFiles('**/poetry.lock') }} - - name: Install dependencies and run + - name: Install dependencies run: | poetry install --no-interaction - poetry run python -m unittest + - name: Start solr + run: poetry run lsolr start-server + - name: Run tests + run: poetry run python -m unittest From 40fa4f6db7c61b223fe5ec1888eedb02ae86e2cf Mon Sep 17 00:00:00 2001 From: Kevin Schaper Date: Fri, 24 Jun 2022 10:41:01 -0700 Subject: [PATCH 2/4] try just python 3.9 --- .github/workflows/pr-test.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pr-test.yaml b/.github/workflows/pr-test.yaml index c3a2d44..cab0698 100644 --- a/.github/workflows/pr-test.yaml +++ b/.github/workflows/pr-test.yaml @@ -10,7 +10,8 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - python-version: [ 3.7.5, 3.8, 3.9 ] +# python-version: [ 3.7.5, 3.8, 3.9 ] + python-version: [ 3.9 ] steps: - uses: actions/checkout@v2 - name: Set up Python ${{ matrix.python-version }} From ef72c847eb2900968d0a6ce649ccebeebb8cd2e8 Mon Sep 17 00:00:00 2001 From: Kevin Schaper Date: Wed, 25 Oct 2023 12:41:28 -0700 Subject: [PATCH 3/4] Test against more versions --- .github/workflows/pr-test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-test.yaml b/.github/workflows/pr-test.yaml index cab0698..72ea34b 100644 --- a/.github/workflows/pr-test.yaml +++ b/.github/workflows/pr-test.yaml @@ -11,7 +11,7 @@ jobs: strategy: matrix: # python-version: [ 3.7.5, 3.8, 3.9 ] - python-version: [ 3.9 ] + python-version: [ 3.8, 3.9, 3.10 ] steps: - uses: actions/checkout@v2 - name: Set up Python ${{ matrix.python-version }} From 3c5856465e8ca02a3284a2249d1c7f09a2820483 Mon Sep 17 00:00:00 2001 From: Kevin Schaper Date: Wed, 25 Oct 2023 12:50:33 -0700 Subject: [PATCH 4/4] quote the python versions so they aren't interpreted as floats --- .github/workflows/pr-test.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/pr-test.yaml b/.github/workflows/pr-test.yaml index 72ea34b..0f9097a 100644 --- a/.github/workflows/pr-test.yaml +++ b/.github/workflows/pr-test.yaml @@ -10,8 +10,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: -# python-version: [ 3.7.5, 3.8, 3.9 ] - python-version: [ 3.8, 3.9, 3.10 ] + python-version: [ "3.8", "3.9", "3.10" ] steps: - uses: actions/checkout@v2 - name: Set up Python ${{ matrix.python-version }}