Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rimworld.StoreUtility.NoStorageBlockersIn - Slamming FPS #124

Open
docssy opened this issue Jun 19, 2022 · 4 comments
Open

Rimworld.StoreUtility.NoStorageBlockersIn - Slamming FPS #124

docssy opened this issue Jun 19, 2022 · 4 comments

Comments

@docssy
Copy link

docssy commented Jun 19, 2022

Hiya LWM,

I'm doing some stress testing and based on the picture, you can see a whole bunch of performance challenges (on purpose).
Anyways, with your storage shelves the game is very much stuttering inside [NoStorageBlockersIn]. I'm seeing about 250,000 calls per second.

PUAH+ / While You Are Up I'm assuming is depending on [NoStorageBlockersIn] to complete as well.

image

Is there any way to refine this code or consider holding a cache of storage and their blockers/contents?

Anything that reduces performance hits on a popular mod is appreciated!

@docssy
Copy link
Author

docssy commented Jun 19, 2022

image
1 second-ish calls

@docssy
Copy link
Author

docssy commented Jun 19, 2022

image
Finally, the stack

@docssy
Copy link
Author

docssy commented Jun 19, 2022

image

And inside [NoStorageBlocksIn]. Note the 2-3ish ms for everything in here, compared to the 1500ms spikes. Something is not being very productive

@LytsePier
Copy link

I've got the exact same problem. This is also taking up 1500ms and slamming my FPS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants