diff --git a/BowlerFile.java b/BowlerFile.java index ebc2b25..0114b5d 100644 --- a/BowlerFile.java +++ b/BowlerFile.java @@ -25,7 +25,7 @@ class BowlerFile implements BowlerDatabase { /** The location of the bowelr database */ - private static String BOWLER_DAT = "/Users/yeonjoo/Desktop/pattern_team/BallingManagementSystem_refactoring/BOWLERS.DAT"; + private static String BOWLER_DAT = "BOWLERS.DAT"; private BowlerFile() {} diff --git a/EndGameReport.java b/EndGameReport.java index 23977c3..ac54d15 100644 --- a/EndGameReport.java +++ b/EndGameReport.java @@ -28,7 +28,7 @@ public class EndGameReport { public EndGameReport( String partyName, Party party ) { result =0; - retVal = new Vector(); + retVal = new Vector<>(); win = new JFrame("End Game Report for " + partyName + "?" ); win.getContentPane().setLayout(new BorderLayout()); ((JPanel) win.getContentPane()).setOpaque(false); @@ -41,13 +41,13 @@ public EndGameReport( String partyName, Party party ) { partyPanel.setLayout(new FlowLayout()); partyPanel.setBorder(new TitledBorder("Party Members")); - Vector myVector = new Vector(); + Vector myVector = new Vector<>(); Iterator iter = (party.getMembers()).iterator(); while (iter.hasNext()){ myVector.add((iter.next()).getNickName() ); } EndGameReportClickEvent listener = new EndGameReportClickEvent(); - memberList = new JList(myVector); + memberList = new JList<>(myVector); memberList.setFixedCellWidth(120); memberList.setVisibleRowCount(5); memberList.addListSelectionListener(listener); @@ -118,7 +118,7 @@ public Vector getretVal(){ return retVal; } public static void main( String args[] ) { - Vector bowlers = new Vector(); + Vector bowlers = new Vector<>(); for ( int i=0; i<4; i++ ) { bowlers.add( new Bowler( "aaaaa", "aaaaa", "aaaaa" ) ); } diff --git a/Lane.java b/Lane.java index 17bd0e5..2cc88ce 100644 --- a/Lane.java +++ b/Lane.java @@ -275,8 +275,7 @@ public int promptEndGame(){ // 게임 종료를 위한 응답 반영 public void printEndGameReportAndNotifyMembers(){ // 점수 보고서 생성 및 출력 Vector printVector; - EndGameReport egr = new EndGameReport( ((Bowler)party.getMembers().get(0)).getNickName() + "'s Party", party); - // TODO: (Bowler) 지우려면 party.getMember type 지정해야 함. + EndGameReport egr = new EndGameReport((party.getMembers().get(0)).getNickName() + "'s Party", party); printVector = egr.waitForResult(); partyAssigned = false; Iterator scoreIt = party.getMembers().iterator(); @@ -377,7 +376,7 @@ public void resetBowlerIterator() { * @post scoring system is initialized */ public void resetScores() { - Iterator bowlIt = (party.getMembers()).iterator(); + Iterator bowlIt = (party.getMembers()).iterator(); while ( bowlIt.hasNext() ) { int[] toPut = new int[25]; @@ -455,9 +454,8 @@ private LaneEvent lanePublish( ) { * * @return The bowlers total score */ - private int getScore( Bowler Cur, int frame) { // 전략 패턴 도입 + private void getScore( Bowler Cur, int frame) { // 전략 패턴 도입 int[] curScore; - int totalScore = 0; curScore = scores.get(Cur); for (int i = 0; i != 10; i++){ cumulScores[bowlIndex][i] = 0; @@ -474,9 +472,7 @@ private int getScore( Bowler Cur, int frame) { // 전략 패턴 도입 strategy = new DefaultScoringStrategy(); } strategy.computeScore(curScore, cumulScores, bowlIndex, current, i); - } - return totalScore; } /** isPartyAssigned() @@ -501,7 +497,7 @@ public boolean isGameHalted(){ return gameIsHalted; } - public Iterator getBowlIterator(){ + public Iterator getBowlIterator(){ return bowlerIterator; } /** subscribe diff --git a/LaneEvent.java b/LaneEvent.java index 1d3800c..e86a6e3 100644 --- a/LaneEvent.java +++ b/LaneEvent.java @@ -38,7 +38,7 @@ public class LaneEvent { int[] curScores; boolean mechProb; - public LaneEvent( Party pty, int theIndex, Bowler theBowler, int[][] theCumulScore, HashMap theScore, int theFrameNum, int[] theCurScores, int theBall, boolean mechProblem) { + public LaneEvent( Party pty, int theIndex, Bowler theBowler, int[][] theCumulScore, HashMaptheScore, int theFrameNum, int[] theCurScores, int theBall, boolean mechProblem) { p = pty; index = theIndex; bowler = theBowler; diff --git a/Queue.java b/Queue.java index 418ca96..6d89664 100644 --- a/Queue.java +++ b/Queue.java @@ -11,14 +11,14 @@ import java.util.Vector; public class Queue { - private Vector v; + private Vector v; /** Queue() * * creates a new queue */ public Queue() { - v = new Vector(); + v = new Vector<>(); } public Object next() { @@ -33,7 +33,7 @@ public boolean hasMoreElements() { return v.size() != 0; } - public Vector asVector() { + public Vector asVector() { return v; } diff --git a/SCOREHISTORY.DAT b/SCOREHISTORY.DAT index 4623074..43eb5a0 100644 --- a/SCOREHISTORY.DAT +++ b/SCOREHISTORY.DAT @@ -33,3 +33,11 @@ Tom 22:34 06/01/2023 149 Jim 22:34 06/01/2023 102 Tom 22:40 06/01/2023 99 TomH 22:40 06/01/2023 108 +Tom 14:20 06/04/2023 127 +Mike 14:20 06/04/2023 153 +Mike 14:35 06/04/2023 126 +Tom 14:35 06/04/2023 141 +Mike 14:50 06/04/2023 152 +Jim 14:50 06/04/2023 177 +Mike 14:51 06/04/2023 111 +Jim 14:51 06/04/2023 129 diff --git a/ScoreHistoryFile.java b/ScoreHistoryFile.java index 0c177f6..18e744b 100644 --- a/ScoreHistoryFile.java +++ b/ScoreHistoryFile.java @@ -11,7 +11,7 @@ public class ScoreHistoryFile implements ScoreHistoryReader, ScoreHistoryWriter { - private static String SCOREHISTORY_DAT = "/Users/yeonjoo/Desktop/pattern_team/BallingManagementSystem_refactoring/SCOREHISTORY.DAT"; + private static String SCOREHISTORY_DAT = "SCOREHISTORY.DAT"; public void addScore(String nick, String date, String score) throws IOException, FileNotFoundException { @@ -26,7 +26,7 @@ public void addScore(String nick, String date, String score) public Vector getScores(String nick) throws IOException, FileNotFoundException { - Vector scores = new Vector(); + Vector scores = new Vector<>(); BufferedReader in = new BufferedReader(new FileReader(SCOREHISTORY_DAT)); diff --git a/ScoringStrategy.java b/ScoringStrategy.java index 80d9017..77ccaa7 100644 --- a/ScoringStrategy.java +++ b/ScoringStrategy.java @@ -1,5 +1,5 @@ interface ScoringStrategy { // 심볼 표시와 점수 계산 인터페이스 String getScoreSymbol(int[] bowlerScores, int ballIndex); - void computeScore(int[] curScore, int[][] cumulScores, int bowlIndex, int current, int i); + void computeScore(int[]curScore, int[][] cumulScores, int bowlIndex, int current, int i); }