Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itests: Add assertions to testCustomChannels to increase test coverage #867

Closed
dstadulis opened this issue Oct 11, 2024 · 3 comments
Closed

Comments

@dstadulis
Copy link

dstadulis commented Oct 11, 2024

Gijs and Roas can enumerate additional test cases from their conversation:
testCustomChannels can have additiona assertions added to increase test coverage

Preliminary testing ideas to inspire ideas:

  • Assert that asset inputs meet stipulations in Limit number of HTLCs in custom channel taproot-assets#1132
  • HTLC errors: forwarding etc
  • Partial shard fulfillment
  • RFQ violations: client side creates a violation, Inconsistency between rate during quote and forwarding (Edge node updates their rate after issuing quote)
  • RFQ tolerance passes within amount or outside of amount
  • very small or large amounts payment amounts, attempts to drain sats balance of channel after asset-channel created
  • Explore any non standard amount / behavior
  • Lost HTLCs due to node dying mid routing process
@gijswijs
Copy link
Contributor

gijswijs commented Dec 2, 2024

There have been quite a few addition to increase test coverage wrt custom channels. @dstadulis I think we should archive this issue.

@dstadulis
Copy link
Author

After CLI forwarding checks are added, Let's close this issue.

@dstadulis
Copy link
Author

Given in situ code, this issue has been satisfied.

@github-project-automation github-project-automation bot moved this from 💇‍♂️Needs Shaping to ✅ Done in Taproot-Assets Project Board Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants