Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config via environment variables #42

Open
johncantrell97 opened this issue Dec 20, 2024 · 1 comment
Open

config via environment variables #42

johncantrell97 opened this issue Dec 20, 2024 · 1 comment

Comments

@johncantrell97
Copy link

I wanted to propose adding support for setting the config via environment variables. They would override anything set in the provided json configuration file. Could also make the config path argument optional and the binary would fail to startup if it cannot get a full Config via env vars.

This repo does not have a Discussion section so adding as an issue.

@G8XSU
Copy link
Contributor

G8XSU commented Dec 27, 2024

Support for setting some configuration values as environment variables definitely makes sense.
However, I am not sure if we should support the entire configuration through environment variables.

I understand the use case for few dynamic values or sensitive data, but are there any other advantages to full config through env vars?

One concern, although minor, is that having multiple sources of configuration could make debugging production deployments during operations more confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants