Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return error when filtering with invalid event id #405

Closed
wants to merge 3 commits into from

Conversation

fmorency
Copy link
Contributor

@fmorency fmorency commented Jul 31, 2023

Fixes #404

An updated Alberto version is required; see liftedinit/alberto#129

@fmorency fmorency added the bug Something isn't working label Jul 31, 2023
@fmorency fmorency requested a review from jgryffindor July 31, 2023 14:53
@fmorency fmorency self-assigned this Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #405 (69c43d7) into main (f97898e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
+ Coverage   82.81%   82.83%   +0.02%     
==========================================
  Files         135      135              
  Lines       15607    15620      +13     
==========================================
+ Hits        12925    12939      +14     
+ Misses       2682     2681       -1     
Files Changed Coverage Δ
src/many-ledger/src/module/event.rs 91.83% <100.00%> (+0.53%) ⬆️
src/many-ledger/src/storage/event.rs 100.00% <100.00%> (ø)
src/many-modules/src/_4_events/list.rs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fmorency
Copy link
Contributor Author

This project will be deprecated soon™, closing.

@fmorency fmorency closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filtering using an non-existing upper bound doesn't work as expected
1 participant