[Feature request] C128 keyboard: 40/80 hotkey and CAPSLOCK indicator

[theflyingape]

Symbolic mapping works great with the notable exception with F7 toggling between 40/80 column mode: it also generates the C128 F7 function key mapped as BASIC "LIST". Can 40/80 toggle be added into the core's Hotkey mapping options for reassignment?

Putting keyboard mapping into Positional mode allows F7 to work separately and appropriately, nice, but then there's no friendly way to know about the emulator's toggle status of capslock using F4. Could a LED icon be added into the C= status bar for that?

[sonninnos]

Ok, I managed to remove the hardcoding of the key so that it works with any keymap. And also noticed the default symbolic map was missing 40/80 and NoScroll, so decided to add them to F9 and F10 since they are free.

Current CapsLock in symbolic is right Alt, and maybe not the best place, but not many other places are available. But it effectively behaves the same as ShiftLock, which is in host CapsLock in any case, so why isn't that keyboard LED enough?

[theflyingape]

All of that sounds great! Is that managed entirely within the core, or are there external vice/data files that need to get replaced in retroarch's system/vice, too?

Not important and was hoping it was a trivial addition, but on my Pi 4/5 tests, the keyboard LED does not toggle suggesting the event is not getting passed to support it. Instead on startup, the CapsLock LED goes ON and remains ON regardless of pressing its key; however functionally, it works as expected within the running core.

[theflyingape]

Not meant to pile on the CapsLock thingy, but the static keyboard LED indicator does that only under KMS; the LED toggles as expected when running under Wayland.

VICE x128 status bar on Pi 5 KDE:

[sonninnos]

Indeed they do not behave the same, since CapsLock affects only letters.

When userport joystick adapters are not in use, there is plenty of space: