Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing compilation on msys2 #17369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Kreijstal
Copy link

@Kreijstal Kreijstal commented Jan 7, 2025

Description

Before there was no clear way of running msys2, and even if there was, there is no guarantee of it working, well I fixed it, and added a CI, so that we can always know if it works. Furthermore I added 2 targets more: UCRT64 and CLANG64, yes, compilation with clang64 means we can also compile with clang for windows on arm :D, plus clang has better error messages overall, anyway.

Related Issues

fixes #17367

Reviewers

Anyone, it's my first PR here.

## Description
Before there was no clear way of running msys2, and even if there was, there is no guarantee of it working, well I fixed it, and added a CI, so that we can always know if it works. Furthermore I added 2 targets more: UCRT64 and CLANG64, yes, compilation with clang64 means we can also compile with clang for windows on arm :D, plus clang has better error messages overall, anyway.

## Related Issues

libretro#17367

## Reviewers
Anyone, it's my first PR here.
@Kreijstal
Copy link
Author

image
Seems it works according to uploaded CI artifacts :D

@shurane
Copy link

shurane commented Jan 8, 2025

This is cool.

Seems like MINGW64 is kind of deprecated anyway: https://www.msys2.org/news/#2022-10-29-changing-the-default-environment-from-mingw64-to-ucrt64. Only for building on Windows 7 and below.

EDIT: Nevermind, guess you already mentioned that in the related issue.

But the docs should probably be updated to suggest that UCRT64 or CLANG64 as the default MSYS2 environment: https://docs.libretro.com/development/retroarch/compilation/windows/

@Kreijstal
Copy link
Author

Should I update the docs?

@shurane
Copy link

shurane commented Jan 8, 2025

I think it makes sense. But I just started working with RetroArch yesterday, and also wondering why it was not using UCRT64/CLANG64 instead of the MINGW64 environment.

@Kreijstal
Copy link
Author

I don't want to be too prescriptive, I'll let the retroarch team handle this for now, then :) Maybe in another PR

@shurane
Copy link

shurane commented Jan 8, 2025

I think the documentation can at least mention that UCRT64 and CLANG64 environments can also be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot compile retroarch on msys2 ucrt64.
2 participants