AutoNAT servers added are not deduplicated

[b-zee]

Summary

Addresses added with autonat::Behaviour::add_server are not deduplicated. This is unlike kad::Behaviour::add_address.

We came across this issue as it was causing us to 'leak' memory, as we kept adding addresses that we were observing. We are adding these servers manually, because in the past we have observed AutoNAT to complain there are no AutoNAT probe servers available (OutboundProbeError::NoServer). This is because by default it uses currently connected peers, but at times there might not be connections to peers causing AutoNAT to not succeed in getting our status. Waiting for our AutoNAT status caused us to further stall our node booting.

Expected behavior

Deduplication

Actual behavior

Duplicated servers in list

Relevant log output

No response

Possible Solution

#4700

Version

master

Would you like to work on fixing this bug ?

Yes