feat: add support for astropy >=6.1.7<8 dependency in pyproject.yaml #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michealroberts
force-pushed
the
feature/dependency/astropy
branch
4 times, most recently
from
8258c8e to
5dd57e7
Compare
michealroberts
commented
Jan 3, 2025
| @@ -1,10 +1,20 @@ | |||
| FROM python:3.11-buster | |||
There was a problem hiding this comment.
@lgrcia Buster is now obsolete, bookworm seems to cover 3.11.11 -> 3.13.1. (see https://hub.docker.com/_/python)
michealroberts
commented
Jan 3, 2025
| @@ -14,8 +14,8 @@ repository = "https://github.com/lgrcia/twirl" | |||
| keywords = ["astronomy", "astrometry", "plate-solving"] | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = "^3.9" | |||
| astropy = "^5.1.1" | |||
| python = ">=3.11,<3.14" | |||
There was a problem hiding this comment.
Pinning to greater than python 3.11 here, as there was a discrepancy between the Dockerfile at 3.11-buster and the version here in the pyproject.toml file.
michealroberts
commented
Jan 3, 2025
.github/workflows/ci.yml
Outdated
| os: [ ubuntu-latest ] | ||
| os: [ubuntu-latest] | ||
| python-version: ["3.11", "3.12", "3.13"] | ||
| astropy-version: ["5.1.1", "6.1.7", "7.0"] |
There was a problem hiding this comment.
Ensure we "test" against all three major versions of astropy.
michealroberts
force-pushed
the
feature/dependency/astropy
branch
2 times, most recently
from
f12b186 to
dae6712
Compare
feat: add support for astropy >=6.1.7<8 dependency in pyproject.yaml
michealroberts
force-pushed
the
feature/dependency/astropy
branch
from
dae6712 to
ff5ede7
Compare
michealroberts
changed the title
|
@lgrcia Due to some PEP 517 build issues, it might be easier to go straight to version 6 and 7 support in the next release ... This would probably make the version a breaking change, unless you're happy to bump in 0.*.0 breaking changes (which is permissible under semver guidelines). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add support for astropy >=6.1.7,<8 dependency in pyproject.yaml
Includes addition support for testings against a matrix of the most recent astropy versions across 6 to 7 by maintaining test support for latest versions of each 6 to 7, i.e., currently
6.1.7and7.0.0.Closes #35