Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search should be work on Internationalized sites #27

Open
hamishwillee opened this issue Nov 17, 2020 · 3 comments · May be fixed by #47
Open

Search should be work on Internationalized sites #27

hamishwillee opened this issue Nov 17, 2020 · 3 comments · May be fixed by #47

Comments

@hamishwillee
Copy link

hamishwillee commented Nov 17, 2020 •
edited
Loading

The default Vuepress search plugin is aware that you're in a multilingual site, and searches only the current language. As this is now I get the same doc in all translations where there is any common text.

EDIT: Note, I could be incorrect here - the default-header only search may simply not show the translations because most headings are translated. Either way it is a flaw - as a user I am would probably only be interested in matching translations as a "last resort"
@hamishwillee hamishwillee changed the title Search should be locale aware Search should be work on Internationalized sites Jan 27, 2021
@hamishwillee
Copy link
Author

Hi @leo-buneev
Is there any way I can feed the current language of the page being displayed into the plugin?
Further, on the home page, if one is displayed, it should/could just use English.

@hamishwillee hamishwillee mentioned this issue Jan 27, 2021
Merged
@pbek
Copy link

pbek commented Jan 31, 2021

vuepress-plugin-fulltext-search is great! But unfortunately I've the same issue when trying to use it on https://www.qownnotes.org/. The whole page, including all translations, is searched when I enter something in the search bar.

@hamishwillee
Copy link
Author

The way this is done in the default search is here: https://github.com/vuejs/vuepress/blob/38e98634af117f83b6a32c8ff42488d91b66f663/packages/%40vuepress/plugin-search/SearchBox.vue#L86

@hamishwillee hamishwillee linked a pull request Apr 30, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only return results that are relevant to current locale hamishwillee/vuepress-plugin-fulltext-search
2 participants
@pbek @hamishwillee