Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preloading starts despite having resources that aren't fully loaded #69

Open
Fulgen301 opened this issue Jan 23, 2022 · 0 comments
Open
Labels
network Network issues

Comments

@Fulgen301
Copy link
Member

C4Game::InitGameFirstPart indirectly calls C4Network2::RetrieveRes as part of the normal loading processs. This is intended behaviour - for example, C4Network2::RetrieveScenario also performs other steps than just loading the scenario.

In rare occasions, however, C4Network2::RetrieveRes then displays the "Wait for resource" dialog that is known from runtime join or starting a game before all resources have been loaded. This should not happen since preloading is only supposed to start after all resources are already loaded. This also causes crashes like #68 since opening a GUI dialog is looping the event loop, which in case of preloading doesn't happen in the main thread.

@Fulgen301 Fulgen301 added bug network Network issues labels Jan 23, 2022
@Fulgen301 Fulgen301 changed the title Preloading started while not all resources are loaded Preloading starts despite having resources that aren't fully loaded Jan 23, 2022
@Fulgen301 Fulgen301 removed the bug label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
network Network issues
Projects
None yet
Development

No branches or pull requests

1 participant