Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icons package #4507

Closed
mica000 opened this issue Nov 10, 2023 · 4 comments · Fixed by #4932
Closed

Update icons package #4507

mica000 opened this issue Nov 10, 2023 · 4 comments · Fixed by #4932
Assignees
Labels
effort:large Expected to take over 1 week of integration work enhancement enhancement-p3 Non-critical functionality wanted by many users, or there are clear alternatives

Comments

@mica000
Copy link

mica000 commented Nov 10, 2023

Replace/Add new icon
All new icons are listed here as exportable SVGs. Faded icons are assumed to not be necessary right now. All icons exist as 16x16 and 24x24 versions. In many cases only either version is actually used.

Move icons to new UI library
Move icons to new UI library and demo them with storybook so that it's easier to see what's currently in use and match those with Figma assets.

TBD/Discussed
Maybe we should seperate token images/icons from UI icons? Right now it can get a bit confusing when looking at the icon folder. In most cases, token icons are actually logos and not icons.

Need help?

  • @fabric-8 is happy to jump in and help with the grunt work of getting the icons in, provided an engineer can put a "template" in place of how we'll handle the icon sizes and what the (updated?) react icon components should look like.
  • Reach out to @fabric-8 to discuss JSX/TSX export options in case the svg export is just too laborious or annoying ✌️ There might be plugin options for conversion.
@mica000

This comment has been minimized.

@markmhendrickson markmhendrickson added Enhancement 💡 enhancement-p3 Non-critical functionality wanted by many users, or there are clear alternatives labels Nov 14, 2023
@mica000 mica000 removed their assignment Dec 18, 2023
@markmhendrickson

This comment has been minimized.

@markmhendrickson markmhendrickson added this to the Establish UI library milestone Jan 2, 2024
@fabric-8 fabric-8 assigned fbwoolf and unassigned fabric-8 Jan 26, 2024
@fbwoolf fbwoolf linked a pull request Feb 9, 2024 that will close this issue
@fbwoolf
Copy link
Contributor

fbwoolf commented Feb 11, 2024

There are two icons still missing we will need to replace in the code:

  1. MegaphoneIcon - currently used in the feedback button
  2. RotateLeftIcon - currently used on the backup secret key page next to Your Secret Key gives access to your wallet

@fbwoolf fbwoolf added the effort:large Expected to take over 1 week of integration work label Feb 13, 2024
@fabric-8
Copy link
Contributor

@fbwoolf Left comments on FIgma regarding the 2 missing icons:

  • MegaphoneIcon was added
  • RotateLeftIcon has been replaced with a different icon (key)

@fbwoolf fbwoolf closed this as completed Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:large Expected to take over 1 week of integration work enhancement enhancement-p3 Non-critical functionality wanted by many users, or there are clear alternatives
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants