Adds ability to preview non-practice resources from the sidepanel #13012
+470
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Coach
Build Artifacts
|
AlexVelezLl
requested changes
Jan 22, 2025
There was a problem hiding this comment.
Hey @AllanOXDi! I have left just a few comments, mainly to migrate this work to the new subPages structure we have for the LessonResourceSelection side panel :). Please let me know if you have any question :)
| @@ -155,18 +155,24 @@ export default [ | |||
| path: 'channels', | |||
| component: SelectFromChannels, | |||
| }, | |||
| { | |||
| name: PageNames.LESSON_PREVIEW_RESOURCE, | |||
| path: 'preview-selected-resources', | |||
There was a problem hiding this comment.
I think the path here could be just "preview" or "preview-resource" as "preview-selected-resources" is not completely acurate and can be confused with path to the shopping cart
There was a problem hiding this comment.
I see that previous to this change, we had a path like this preview-resources/:nodeId:
{
name: PageNames.LESSON_PREVIEW_RESOURCE,
path: 'preview-resources/:nodeId',
component: PreviewSelectedResources,
},Was there any reason to change the path and the param to be a query?
There was a problem hiding this comment.
I don't think there was a particular reason to
kolibri/plugins/coach/assets/src/composables/useFetchContentNode.js
Outdated
Show resolved
Hide resolved
kolibri/plugins/coach/assets/src/views/lessons/LessonSummaryPage/sidePanels/PreviewContent.vue
Outdated
Show resolved
Hide resolved
kolibri/plugins/coach/assets/src/views/lessons/LessonSummaryPage/sidePanels/PreviewContent.vue
Show resolved
Hide resolved
kolibri/plugins/coach/assets/src/views/lessons/LessonSummaryPage/sidePanels/PreviewContent.vue
Show resolved
Hide resolved
kolibri/plugins/coach/assets/src/views/lessons/LessonSummaryPage/sidePanels/PreviewContent.vue
Outdated
Show resolved
Hide resolved
kolibri/plugins/coach/assets/src/views/lessons/LessonSummaryPage/sidePanels/PreviewContent.vue
Outdated
Show resolved
Hide resolved
kolibri/plugins/coach/assets/src/views/lessons/LessonSummaryPage/sidePanels/PreviewContent.vue
Outdated
Show resolved
Hide resolved
kolibri/plugins/coach/assets/src/views/lessons/LessonSummaryPage/sidePanels/PreviewContent.vue
Outdated
Show resolved
Hide resolved
kolibri/plugins/coach/assets/src/views/lessons/LessonSummaryPage/sidePanels/PreviewContent.vue
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated the KCard in the resource selection in lessons to navigate to preview resources.
Used the existing content renderer to display the content using the /lessonstemp/ path in the updated side panel.
Before
After
Closes #12988
References
#12988
Reviewer guidance
lessonstemppath.Currently not implemented
Ability to add a resource to a lesson
Have not figured out what triggered the KBreadcrumbs error in the console
…