0.18 - 'Select device' modal - Disabled server address

[pcenov]

Observed behavior

If I have manually added a device in the 'Select device' modal, then when I restart the Kolibri server and attempt again to import resources from this device it is grayed out. If I remove it and add it again it can be accessed correctly until the next restart of the server:

disabled.mp4

The following request is returning a 500 error: http://127.0.0.1:8080/api/discovery/networklocation/073da5ede5324d2285df0cbc1a7c71c8/update_connection_status/

Expected behavior

The device should not be disabled if it's available and can be accessed.

Steps to reproduce the issue

1. Install the build asset from https://github.com/learningequality/kolibri/releases/tag/v0.18.0-alpha0
2. Go to Device > Channels > Import > Local network or internet
3. Add a new device such as "https://hotfixes.studio.learningequality.org/"
4. Restart Kolibri
5. Go again to Device > Channels > Import > Local network or internet and observe that the device is disabled

Usage Details

https://github.com/learningequality/kolibri/releases/tag/v0.18.0-alpha0
Ubuntu 22 - Chrome

[pcenov]

@radinamatic

[radinamatic]

Just an additional detail: in my testing it was not even necessary to restart Kolibri server for the device to appear grayed out, it happens as soon as the user attempts a second import (new channel, or additional resources from the same one), it becomes inactive (unreachable), The only way out is to remove the device and add it again, mighty annoying... 😒

[Varun-Kolanu]

The device data that is coming from /networklocation endpoint for the url https://hotfixes.studio.learningequality.org has operating_system field as an empty string. Due to which /update_connection is facing an error:

So, due to the not null constraint is the reason.
I traced back the endpoints and found that platform.system() is not able to determine operating system of the machine where the Kolibri Studio is hosted on.

Location of endpoints:
kolibri/core/public/api.py, line 69: (get_device_info..) and
kolibri/core/device/utils.py, line 469 (platform.system())

So, I would like to know if this error persists in your testing for other urls too?
Because I tested some of the urls like a local network of kolibri app running on my mobile and I found it was working fine for those. (But all the Kolibri studio urls are facing the issue because /api/public/info of those is returning operating_system: null)

[nucleogenesis]

Thanks for the thorough and helpful notes @Varun-Kolanu!

It appears that this issue may be specifically affecting Studio (prod and hotfixes). I've run into this exact issue several times as I've had to import from Hotfixes and it seems that my assumption that it was specific to Hotfixes is confirmed by my testing.

I added kolibri-demo.learningequality.org to my remotes and it remained active and never hit the error about the operating_system being null. But, if I put studio.learningequality.org (or hotfixes.) the bug reported here would show itself.

@pcenov does this match your experience?

If so, I think that we can probably deprioritize this bug or possibly even migrate it to the Studio repo as it appears we're just not getting the data when we get the device info for a Studio instance.

[pcenov]

Hi @nucleogenesis - yes I confirm that the issue appears to be valid only for studio urls and not for other devices or urls:

[rtibbles]

I think the best thing here is just to handle the operating_system being null in the response, and make sure we handle that and set it to "" in that case, as the field can be set as blank just not as null.