Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for PERIOD_VOTE tx type #282

Closed
johannbarbie opened this issue Jun 26, 2019 · 3 comments · Fixed by #305
Closed

add support for PERIOD_VOTE tx type #282

johannbarbie opened this issue Jun 26, 2019 · 3 comments · Fixed by #305
Assignees
Labels
bounty size-M effort of ~8h
Milestone

Comments

@johannbarbie
Copy link
Member

johannbarbie commented Jun 26, 2019

Bounty

period vote transaction are used by validators to signal on data availability of 32-block chunks.

Scope

  • enable node to handle period vote txns
  • in check bridge, replace period submission with broadcast of periodSubmision txns
  • in check bridge, build CAS bitmap and submit period if >2/3 of periodVotes available

Deliverables

  • code
  • tests

Gain for the project

  • ability to run PoS

Publicly visible delivery

Roles

bounty gardener: @johannbarbie / 5%
bounty worker: @troggy / 75%
bounty reviewer: @johannbarbie / 20%

@johannbarbie johannbarbie added this to the CAS milestone Jun 26, 2019
@pinkiebell
Copy link
Contributor

Looks good. Interesting would be the case if we can't get 2/3 of votes for the period. How is that handled? Chain stops and waits or just move on?

@johannbarbie johannbarbie added the size-M effort of ~8h label Jul 4, 2019
@troggy troggy self-assigned this Aug 1, 2019
@troggy
Copy link
Member

troggy commented Aug 2, 2019

Integration tests are out of scope and to be done here: leapdao/leap-sandbox#39

@troggy
Copy link
Member

troggy commented Aug 7, 2019

I've found a non-determinism in multi-validator setup: validators disagree on a few blocks per period, leading to different period roots.
This seems like a time sink, so I’d like to remove period submission from the scope of this bounty

Looks like an issue in my test setup (e.g. when one of the validator is restarted). In "normal" scenario works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty size-M effort of ~8h
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants