Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make extern decls evaluate as ⊤ instead of ⊥ in LCNF.elimDeadBranches #6928

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: make extern decls evaluate as ⊤ instead of ⊥ in LCNF.elimDeadBranches #6928

wants to merge 1 commit into from
+3 −1

Conversation

zwarich
Copy link
Contributor

@zwarich zwarich commented Feb 3, 2025

This PR makes extern decls evaluate as ⊤ rather than the default value of ⊥ in the LCNF elimDeadBranches analysis.

@zwarich zwarich added the changelog-compiler Compiler, runtime, and FFI label Feb 3, 2025
@zwarich zwarich requested a review from leodemoura as a code owner February 3, 2025 21:07
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Feb 3, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase c6cb2f52f028882ff821394f447d569898546803 --onto 832d7c500d709deb5e7f0a5a6fd0f01865d1a303. (2025-02-03 21:28:43)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

Assignees
No one assigned
Labels
changelog-compiler Compiler, runtime, and FFI toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zwarich @leanprover-community-bot