Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unnecessary simp priorities #6812

Merged
merged 1 commit into from
Jan 29, 2025
Merged

chore: remove unnecessary simp priorities #6812

merged 1 commit into from
Jan 29, 2025
+13 −13

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Jan 28, 2025

This PR remove simp priorities that are not needed. Some of these will probably cause complaints from the simpNF linter downstream in Batteries, which I will re-address separately.

@kim-em kim-em added the awaiting-mathlib We should not merge this until we have a successful Mathlib build label Jan 28, 2025
@kim-em kim-em requested a review from digama0 as a code owner January 28, 2025 06:49
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 28, 2025 07:02 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 28, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 28, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6812
ba350bc
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 28, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6812
050c0e4
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Jan 28, 2025 •
edited
Loading

Mathlib CI status (docs):

@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Jan 28, 2025
kim-em added a commit to leanprover-community/batteries that referenced this pull request Jan 28, 2025
@kim-em
fixes for leanprover/lean4#6812
d5ab37b
kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 28, 2025
@kim-em
lake update for leanprover/lean4#6812
cb21752
@kim-em kim-em removed the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Jan 28, 2025
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Jan 28, 2025
@kim-em kim-em removed the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Jan 28, 2025
kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 28, 2025
@kim-em
touch for CI for leanprover/lean4#6812
9bac19a
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Jan 28, 2025
kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 28, 2025
@kim-em
fix for leanprover/lean4#6812
986dafc
@kim-em kim-em removed the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Jan 28, 2025
@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed awaiting-mathlib We should not merge this until we have a successful Mathlib build labels Jan 28, 2025
@kim-em kim-em enabled auto-merge January 28, 2025 23:50
@kim-em kim-em added this pull request to the merge queue Jan 28, 2025
Merged via the queue into master with commit 9b5fadd Jan 29, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digama0 digama0 Awaiting requested review from digama0 digama0 is a code owner

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kim-em @leanprover-community-bot