Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow simp priority explanations #6811

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: allow simp priority explanations #6811

wants to merge 1 commit into from

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Jan 28, 2025

This PR allows writing @[simp 1100 "This simp lemma is higher priority to fire before Foo."].

Aspirationally, we would eventually require such explanations in Mathlib for all priority changes, as these otherwise quickly become inexplicable.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 28, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 20c616503abe5ce4253c56dbcd7766a91c675ba0 --onto 69a73a18fbfa1fc045bfbf1c4cf93b155d4c9387. (2025-01-28 06:22:01)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digama0 digama0 Awaiting requested review from digama0 digama0 will be requested when the pull request is marked ready for review digama0 is a code owner

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kim-em @leanprover-community-bot