Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: #check_failure's output should be info, instead of warning #6684

Closed
Seasawher opened this issue Jan 18, 2025 · 0 comments · Fixed by #6685
Closed

RFC: #check_failure's output should be info, instead of warning #6684

Seasawher opened this issue Jan 18, 2025 · 0 comments · Fixed by #6685
Labels
RFC Request for comments

Comments

@Seasawher
Copy link
Contributor

Proposal

Since #check_failure is a command that asserts an intentional failure, its output should be info, not warning.

Community Feedback

Zulip: >#check_failure's output should be info, not warning

Impact

Add 👍 to issues you consider important. If others benefit from the changes in this proposal being added, please ask them to add 👍 to it.
@Seasawher Seasawher added the RFC Request for comments label Jan 18, 2025
@Seasawher Seasawher mentioned this issue Jan 18, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 18, 2025
@Seasawher
fix: make #check_failure's output be info (#6685)
98e3d6f 
This PR fixes the issue that `#check_failure`'s output is warning

Closes #6684
luisacicolini pushed a commit to opencompl/lean4 that referenced this issue Jan 21, 2025
@Seasawher @luisacicolini
fix: make #check_failure's output be info (leanprover#6685)
e57245c 
This PR fixes the issue that `#check_failure`'s output is warning

Closes leanprover#6684
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
RFC Request for comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make #check_failure's output be info Seasawher/lean4
1 participant
@Seasawher