-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lake: local package overrides #6411
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tydeu
force-pushed
the
lake/package-overrides
branch
from
December 18, 2024 02:07
3c9382d
to
c65422e
Compare
github-actions
bot
added
the
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
label
Dec 18, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Dec 18, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 18, 2024
leanprover-community-bot
added
the
builds-mathlib
CI has verified that Mathlib builds against this PR
label
Dec 18, 2024
Mathlib CI status (docs):
|
tydeu
force-pushed
the
lake/package-overrides
branch
from
December 18, 2024 06:50
c65422e
to
ba01e03
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Dec 18, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 18, 2024
luisacicolini
pushed a commit
to opencompl/lean4
that referenced
this pull request
Jan 21, 2025
This PR adds the ability to override package entries in a Lake manifest via a separate JSON file. This file can be specified on the command line with `--packages` or applied persistently by placing it at `.lake/package-overrides.json`. The overrides file is a subset of `lake-manifest.json` with just a version and a `packages` field. The entries in the package share the syntax of the manifest file and take precedence over the entries there. Lake loads the entries from the manifest, then overrides them with those in `.lake/package-overrides.json` (if any) and then those in any file passed to `--packages`.
JovanGerb
pushed a commit
to JovanGerb/lean4
that referenced
this pull request
Jan 21, 2025
This PR adds the ability to override package entries in a Lake manifest via a separate JSON file. This file can be specified on the command line with `--packages` or applied persistently by placing it at `.lake/package-overrides.json`. The overrides file is a subset of `lake-manifest.json` with just a version and a `packages` field. The entries in the package share the syntax of the manifest file and take precedence over the entries there. Lake loads the entries from the manifest, then overrides them with those in `.lake/package-overrides.json` (if any) and then those in any file passed to `--packages`.
Does this mean that |
@eric-wieser |
I think there is quite a lot of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
builds-mathlib
CI has verified that Mathlib builds against this PR
changelog-lake
Lake
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to override package entries in a Lake manifest via a separate JSON file. This file can be specified on the command line with
--packages
or applied persistently by placing it at.lake/package-overrides.json
.The overrides file is a subset of
lake-manifest.json
with just a version and apackages
field. The entries in the package share the syntax of the manifest file and take precedence over the entries there. Lake loads the entries from the manifest, then overrides them with those in.lake/package-overrides.json
(if any) and then those in any file passed to--packages
.