Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add shot-per-shot total intensity option to run_analysis task #374

Closed
fredericpoitevin opened this issue Apr 16, 2024 · 1 comment · Fixed by #377
Closed

ENH: add shot-per-shot total intensity option to run_analysis task #374

fredericpoitevin opened this issue Apr 16, 2024 · 1 comment · Fixed by #377
Assignees
Labels
enhancement New feature or request

Comments

@fredericpoitevin
Copy link
Collaborator

fredericpoitevin commented Apr 16, 2024

Goal: add an option to the run_analysis task to add a key to self.stats that contains an array of the total intensity per event.

Expected behavior:

rd = RunDiagnostics(exp='amo11416',run=143,det_type='pnccdFront')
rd.compute_run_stats(total_intensity=True)
rd.stats['total_intensity'] # <== returns an array that contains the total intensity for each event in the run.

In terms of command-line usage, the behavior should be something like:

elog_submit.sh -c config.yaml -t run_analysis -n 120 ...

where config.yaml has the additional argument for the run_analysis task, something like:

run_analysis:
  total_intensity: True
@fredericpoitevin fredericpoitevin added the enhancement New feature or request label Apr 16, 2024
@fredericpoitevin
Copy link
Collaborator Author

Turns out we already have something very similar with self.stats_final['mean'] which is displayed back in the eLog thanks to self.visualize_stats()
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants