Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect a PgListener with PgConnectOptions #3631

Open
Virgiel opened this issue Dec 7, 2024 · 1 comment
Open

Connect a PgListener with PgConnectOptions #3631

Virgiel opened this issue Dec 7, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Virgiel
Copy link

Virgiel commented Dec 7, 2024 •
edited
Loading

Pool has two connect function variants, one from a raw Postgres URI connect and one from a typed PgConnectOptions connect_with.
PgListener also has two connect function variants, one from a raw Postgres URI connect and one from a pool connect_with.

I need a function to use PgConnectOptions to connect a PgListener.

As connect_with has already been taken, a non-breaking solution would be connect_with_option.
In my opinion, we should have connect, connect_with and connect_with_pool to match the names of the Pool functions.
@Virgiel Virgiel added the enhancement New feature or request label Dec 7, 2024
@nMessage
Copy link

nMessage commented Dec 9, 2024

is #2924 related to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Virgiel @nMessage