[Local Editor Styling Updates] #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zakariassoul
requested review from
saqadri,
rholinshead,
suyoglastmileai,
Ankush-lastmile,
jonathanlastmileai and
rossdanlm
as code owners
This was referenced Jan 8, 2024
rholinshead
reviewed
Jan 8, 2024
Comment on lines
299
to
351
| ".mantine-InputWrapper-label": { | ||
| display: "none", | ||
| }, |
There was a problem hiding this comment.
these are going to apply to every mantine input label, right? I'm pretty sure we don't want that -- is this intended only for the prompt name / input label?
There was a problem hiding this comment.
I moved it to be only applied to input fields within the cell container
|
@rholinshead this should pass and have all fixes |
rholinshead
reviewed
Jan 9, 2024
| @@ -276,6 +291,9 @@ export default function Editor() { | |||
| color: "white", | |||
| borderRadius: "0", | |||
| height: "auto", | |||
| "&:hover": { | |||
| background: "#ff46f8", | |||
There was a problem hiding this comment.
One thing to look into afterwards -- we can set a primaryColory with the 10 different shades and it will automatically apply to all button backgrounds, hover, highlight around text area, etc. without needing to manually do it.
rholinshead
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Local Editor Styling Updates]