[AiConfig Branded Editor] #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zakariassoul
requested review from
saqadri,
rholinshead,
suyoglastmileai,
Ankush-lastmile,
jonathanlastmileai and
rossdanlm
as code owners
Screen.Recording.2024-01-05.at.9.27.12.AM.mov |
rholinshead
reviewed
Jan 5, 2024
python/src/aiconfig/editor/client/src/components/prompt/ModelSelector.tsx
Show resolved
Hide resolved
python/src/aiconfig/editor/client/src/components/prompt/RunPromptButton.tsx
Outdated
Show resolved
Hide resolved
rholinshead
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Accepting to unblock once the following changes are made:
- update prompt run button class name to be more generic
- move aiconfig image up to root Editor.tsx component; this is the local editor-specific component. The component will be shared between local editor, gradio and readonly lastmile renderer
rholinshead
reviewed
Jan 5, 2024
python/src/aiconfig/editor/client/src/components/EditorContainer.tsx
Outdated
Show resolved
Hide resolved
zakariassoul
force-pushed
the
pr777
branch
3 times, most recently
from
71371bc to
7183a11
Compare
I styled the local editor to match ai-config brand colors. This is just iteration 1...more to come
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[AiConfig Branded Editor]
I styled the local editor to match ai-config brand colors. This is just iteration 1...more to come